sentry/time: fix deadlock in GetTime by avoiding resetLocked under re… - #14162
Closed
Rajkaran-122 wants to merge 1 commit into
Closed
sentry/time: fix deadlock in GetTime by avoiding resetLocked under re…#14162Rajkaran-122 wants to merge 1 commit into
Rajkaran-122 wants to merge 1 commit into
Conversation
…ad lock The GetTime function was calling resetLocked() while holding a read lock, but resetLocked expects a write lock since it modifies the clock state. This could cause a deadlock. Fix by releasing the read lock before calling reset, which acquires the necessary write lock internally. Also removes the outdated TODO comment about sequence counters. Fixes google#181.
EtiennePerot
approved these changes
Aug 18, 2026
Collaborator
|
The PR looks correct but doesn't match the description. There's no deadlock here, and the issue it claims to fix is about removing the need for locks entirely. A PR that aims to fix it needs to meet that bar. |
Author
|
@EtiennePerot sir fixed in please review #14195 the pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetTime function was calling resetLocked() while holding a read lock, but resetLocked expects a write lock since it modifies the clock state. This could cause a deadlock.
Fix by releasing the read lock before calling reset, which acquires the necessary write lock internally. Also removes the outdated TODO comment about sequence counters.
Fixes #181.