sentry/time: fix deadlock in GetTime by avoiding resetLocked under re… - #14172
Open
copybara-service[bot] wants to merge 1 commit into
Open
sentry/time: fix deadlock in GetTime by avoiding resetLocked under re…#14172copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The GetTime function was calling resetLocked() while holding a read lock, but resetLocked expects a write lock since it modifies the clock state. This could cause a deadlock. Fix by releasing the read lock before calling reset, which acquires the necessary write lock internally. Also removes the outdated TODO comment about sequence counters. Fixes #181. FUTURE_COPYBARA_INTEGRATE_REVIEW=#14162 from Rajkaran-122:contrib/fix-sentry-time-read-lock 85cd528 PiperOrigin-RevId: 966692033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry/time: fix deadlock in GetTime by avoiding resetLocked under re…
The GetTime function was calling resetLocked() while holding a read lock, but resetLocked expects a write lock since it modifies the clock state. This could cause a deadlock.
Fix by releasing the read lock before calling reset, which acquires the necessary write lock internally. Also removes the outdated TODO comment about sequence counters.
Fixes #181.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#14162 from Rajkaran-122:contrib/fix-sentry-time-read-lock 85cd528