Skip to content

fix(scripts): use ASCII [OK] marker in initialize-repo.sh (parity with PowerShell twin) #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 2 commits into from
Jun 29, 2026
+5 −1
Merged

fix(scripts): use ASCII [OK] marker in initialize-repo.sh (parity with PowerShell twin) #3231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
629a6c8
fix(scripts): use ASCII [OK] marker in initialize-repo.sh (parity wit…
jawwad-ali Jun 29, 2026
aa602e6
test: assert full [OK] init line and surface stderr on failure
jawwad-ali Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/git/scripts/bash/initialize-repo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ _git_out=$(git init -q 2>&1) || { echo "[specify] Error: git init failed: $_git_
_git_out=$(git add . 2>&1) || { echo "[specify] Error: git add failed: $_git_out" >&2; exit 1; }
_git_out=$(git commit --allow-empty -q -m "$COMMIT_MSG" 2>&1) || { echo "[specify] Error: git commit failed: $_git_out" >&2; exit 1; }

echo "✓ Git repository initialized" >&2
echo "[OK] Git repository initialized" >&2
4 changes: 4 additions & 0 deletions tests/extensions/git/test_git_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ def test_initializes_git_repo(self, tmp_path: Path):
result = _run_bash("initialize-repo.sh", project)
assert result.returncode == 0, result.stderr

# Success marker is the full ASCII "[OK] ..." line (matching the PowerShell
# twin and the sibling auto-commit scripts), not a Unicode checkmark.
assert "[OK] Git repository initialized" in result.stderr, result.stderr

# Verify git repo exists
assert (project / ".git").exists()

Expand Down