fix(scripts): use ASCII [OK] marker in initialize-repo.sh (parity with PowerShell twin)#3231
Merged
mnriem merged 2 commits intoJun 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the Git extension’s Bash initialize-repo.sh success output with the ASCII [OK] marker used by the PowerShell twin and other sibling scripts, and updates the Bash test to assert the new marker.
Changes:
- Replace the Unicode checkmark success marker in
initialize-repo.shwith[OK]. - Extend the Bash initialize-repo test to assert the
[OK]success marker is present on stderr.
Show a summary per file
| File | Description |
|---|---|
extensions/git/scripts/bash/initialize-repo.sh |
Changes the success message marker from a Unicode checkmark to ASCII [OK] for consistency and safer console rendering. |
tests/extensions/git/test_git_extension.py |
Adds an assertion that the Bash script emits the [OK] marker on successful initialization. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
…h PowerShell twin)
initialize-repo.sh printed its success line with a Unicode checkmark ('✓ Git repository initialized'), while the PowerShell twin initialize-repo.ps1 and both auto-commit scripts use the ASCII marker '[OK]'. That is an output-text divergence across the bash/PowerShell twins and an inconsistency among sibling extension scripts. Use '[OK]' to match.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address Copilot review: assert the full success line '[OK] Git repository initialized' (not just the '[OK]' substring, which could pass if unrelated [OK] output is added later) and include result.stderr in the assertion message so a failure is debuggable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jawwad-ali
force-pushed
the
fix/initialize-repo-ascii-ok-marker
branch
from
d0d4f16 to
aa602e6
Compare
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
initialize-repo.shprinted its success line with a Unicode checkmark:But its PowerShell twin and the sibling extension scripts all use the ASCII marker
[OK]:initialize-repo.ps1:Write-Host "[OK] Git repository initialized"auto-commit.sh:echo "[OK] Changes committed ..."auto-commit.ps1:Write-Host "[OK] Changes committed ..."So
initialize-repo.shis the lone outlier — an output-text divergence across the bash/PowerShell twins and an inconsistency among sibling extension scripts (the Unicode marker can also render as a mojibake box in consoles that aren't UTF-8).Fix
Use
[OK]to match the twin and siblings. One-line change.Testing
uvx ruff checkclean.TestInitializeRepoBash::test_initializes_git_repoto assert the success marker[OK]is present on stderr.AI Disclosure
Found and fixed with Claude Code (Claude Opus 4.8) under my direction. AI located the lone Unicode marker among the otherwise-ASCII sibling/twin scripts; I confirmed the twin and auto-commit scripts use
[OK]and that no test depended on the checkmark, and reviewed the diff before submitting.