test(alerts): clear localStorage between anomaly banner tests - #121172
Open
JoshuaKGoldberg wants to merge 3 commits into
Open
test(alerts): clear localStorage between anomaly banner tests#121172JoshuaKGoldberg wants to merge 3 commits into
JoshuaKGoldberg wants to merge 3 commits into
Conversation
anomalyDetectionFeedbackBanner's 'submits anomaly detection feedback (yes)' fails 49 of 50 stressed runs. The banner records dismissal in localStorage keyed by incident id via useDismissable, and jsdom keeps that store for the whole file, so only the first run sees a banner to click. The sibling test passes only because it uses a different incident id. Clearing localStorage in beforeEach makes it repeatable, so the it.isKnownFlake() marker comes off too. Refs LOGS-936
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
commented
Aug 4, 2026
This was referenced Aug 4, 2026
JoshuaKGoldberg
marked this pull request as ready for review
August 4, 2026 16:01
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
natemoo-re
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anomalyDetectionFeedbackBanner→submits anomaly detection feedback (yes)fails all but the first of its runs when run repeatedly. The banner records dismissal inlocalStoragekeyed by incident id viauseDismissable, but never clears out the key.Fixed by clearing
localStorageinbeforeEach.Follow-up to a follow-up on LOGS-936