test: clear remaining stale flaky markers - #121173
Closed
JoshuaKGoldberg wants to merge 1 commit into
Closed
Conversation
Removes the 30 remaining it.isKnownFlake() markers across 17 files, leaving zero usages in static/. The helper, its type declaration, and the CI wiring stay in place for future use. These markers are stale. All date to automation batches merged on 2026-05-26, 06-03, and 06-08; the automation only ever adds markers, and its last three PRs (#117642, #118116, #118627) were closed unmerged, so nothing has marked or unmarked anything on master in seven weeks. Eleven of the files have had no commit since their marker landed. Every marked test passes in isolation, and 37 of 38 passed 50x stress across two full passes (3928 executions). None of these files appears among the 49 jest issues currently unresolved in Sentry, while many unmarked files do. The marker is a no-op in normal CI, expanding to 50 runs only when the Frontend: Rerun Flaky Tests label sets RERUN_KNOWN_FLAKY_TESTS. Removing it changes no default CI behavior; it stops advertising these tests as flaky. Refs LOGS-936
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #121172 — review that one first.
I audited every remaining
it.isKnownFlake()marker in the repo. #121172 fixes the only genuine flake I could find. This removes the other 30 markers across 17 files, which leaves zero usages instatic/. The helper, its type declaration, and the CI wiring stay in place for future use.The case for removing them is that the markers are unmaintained, not that these tests never fail. All 30 date to automation batches merged on 2026-05-26, 06-03, and 06-08. The automation only ever adds markers, and its last three PRs (#117642, #118116, #118627) were closed unmerged, so it has not revisited anything on master since. Eleven of the files have had no commit since their marker landed. Locally, every marked test passes in isolation, and 37 of 38 passed 50x stress across two full passes (3928 executions).
Two of these tests did fail on master in the last five weeks. Both were reported to #feed-frontend-tests and both are now resolved in Sentry:
explore/metrics/metricsTab.spec.tsx→should add a metric when Add Metric button is clicked(JEST-2XZ0, 1 event, 2026-07-14)dashboards/widgetCard/spansWidgetQueries.spec.tsx→calculates the confidence for a multi series(JEST-21WY, 3 events, last seen 2026-07-02)Of the 12 distinct issues that channel reported between 07-01 and 08-04, those are the only two I could attribute to a marked test; one alert (JEST-2Y29) has no spec frame in its stack, so I could not attribute it either way. Neither hit is among the jest issues currently unresolved. I'm still proposing to unmark both, but flagging them so that's a deliberate call rather than an omission.
The marker is a no-op in normal CI, expanding to 50 runs only when the
Frontend: Rerun Flaky Testslabel setsRERUN_KNOWN_FLAKY_TESTS. Removing it changes no default CI behavior, and it does not make a flaky test any likelier to fail — it stops advertising these tests as flaky. If either of the two above regresses, the Sentry alert is the signal that matters, and it fires with or without the marker.Replaces #120851, which bundled the banner fix in with the marker removals.
Follow-up to a follow-up on LOGS-936