Repository navigation
feat(descriptions): Add descriptions for AWS SDK spans by service, operation and resource - #717
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
pabloDeputter
changed the base branch from
main
to
pablo/aws-resource-name-attributes
October 14, 2026 13:24
pabloDeputter
marked this pull request as ready for review
October 14, 2026 13:44
pabloDeputter
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
giortzisg,
mjq and
nsdeschenes
as code owners
October 14, 2026 13:44
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
pabloDeputter
force-pushed
the
pablo/aws-sdk-span-descriptions
branch
from
October 16, 2026 11:50
5b2f4cf to
25fa916
Compare
Lms24
approved these changes
Oct 20, 2026
pabloDeputter
force-pushed
the
pablo/aws-sdk-span-descriptions
branch
from
October 23, 2026 11:10
25fa916 to
fea8924
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fea8924. Configure here.
pabloDeputter
added a commit
that referenced
this pull request
Oct 23, 2026
…name attributes (#716) ## Description Adds the following attributes (non-OTel): - `aws.lambda.target_function.name`: the function a Lambda API call acts on (`GetFunction`, `UpdateFunctionCode`, …) - `aws.step_functions.state_machine.name` - `aws.step_functions.activity.name` - `aws.secretsmanager.secret.name`: from the `Name` Secrets Manager returns ## Why Next PR (#717) in stack adds descriptions for AWS SDK spans by service, operation and resource, e.g. `SecretsManager.GetSecretValue db-password`. Other services already have a short name for this (`aws.s3.bucket`, `aws.kinesis.stream_name`, `faas.invoked_name`). These only had the full ARN, e.g. `arn:aws:secretsmanager:us-east-1:123456789012:secret:db-password-AbCdEf`, which is too long and already in the respective ARN attribute. All of these resource names are already part of the ARNs we collect, so no new data is sent.
…n and destination
pabloDeputter
force-pushed
the
pablo/aws-sdk-span-descriptions
branch
from
October 23, 2026 11:15
fea8924 to
66a2bfb
Compare
…ws.lambda.function.name`
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds description templates so it follows the same format like the
object.*descriptions in #707:<Service>.<Operation> <resource>.rpcLambda.Invoke)Lambda.Invoke billing,SecretsManager.GetSecretValue db-password,SQS.ChangeMessageVisibility orders;S3.ListBuckets(operations with no resource)db(DynamoDB, nodb.query.text)GetItem orders)DynamoDB.GetItem orders,DynamoDB.Query orders.by-status,DynamoDB.BatchGetItem customers, orders,DynamoDB.ListTablesqueue.*(SQS, SNS)ordersSQS.SendMessageBatch orders,SNS.Publish alertsOnly AWS SDK spans have
rpc.serviceandrpc.method, so otherrpc,dband messaging spans are unaffected;dbspans that contain thedb.query.textattribute keep it as as their description.