Repository navigation
feat(attributes): Add AWS Lambda, Step Functions and Secrets Manager name attributes - #716
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
pabloDeputter
marked this pull request as ready for review
October 14, 2026 13:44
pabloDeputter
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
giortzisg,
mjq and
nsdeschenes
as code owners
October 14, 2026 13:44
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f60aee. Configure here.
This was referenced Oct 16, 2026
Lms24
approved these changes
Oct 19, 2026
pabloDeputter
added a commit
to getsentry/sentry-python
that referenced
this pull request
Oct 19, 2026
### Description Adds the following attributes: - `aws.secretsmanager.secret.arn` (OTel): from an ARN `SecretID`, replaced by the response `ARN` (if available). - `aws.secretsmanager.secret.name` (getsentry/sentry-conventions#716): from response `Name` or the request `Name` or `SecretId`, else the ARN without its random `-XXXXXX` suffix (in case of failed calls). The actual secret values are never read. #### Issues Resolves #7574
pabloDeputter
added a commit
to getsentry/sentry-python
that referenced
this pull request
Oct 19, 2026
## Description Adds the following attributes: - `aws.step_functions.state_machine.arn`, `*.activity.arn` (OTel) and `*.execution.arn` (getsentry/sentry-conventions#672), from the request and response. - `aws.step_functions.state_machine.name` and `*.activity.name` (getsentry/sentry-conventions#716), from `name` on create calls or from the ARN without its version/alias qualifier. Whenever `StartSyncExecution` returns a failed call (`FAILED` or `TIMED_OUT`), `error.type` will be set to the respective value. ### Issues Resolves #7478
…name attributes Add `aws.lambda.function.name`, `aws.step_functions.state_machine.name`, `aws.step_functions.activity.name` and `aws.secretsmanager.secret.name`.
pabloDeputter
force-pushed
the
pablo/aws-resource-name-attributes
branch
from
October 23, 2026 11:10
373b2bb to
fb49b2c
Compare
4 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following attributes (non-OTel):
aws.lambda.target_function.name: the function a Lambda API call acts on (GetFunction,UpdateFunctionCode, …)aws.step_functions.state_machine.nameaws.step_functions.activity.nameaws.secretsmanager.secret.name: from theNameSecrets Manager returnsWhy
Next PR (#717) in stack adds descriptions for AWS SDK spans by service, operation and resource, e.g.
SecretsManager.GetSecretValue db-password. Other services already have a short name for this (aws.s3.bucket,aws.kinesis.stream_name,faas.invoked_name). These only had the full ARN, e.g.arn:aws:secretsmanager:us-east-1:123456789012:secret:db-password-AbCdEf, which is too long and already in the respective ARN attribute.All of these resource names are already part of the ARNs we collect, so no new data is sent.