Repository navigation
Bump yannelli/prompt-manager to v0.4.1 - #179
Conversation
There was a problem hiding this comment.
Needs from you: nothing, merged
Prompt Manager v0.4.1 adds the OVERVIEW.md that blocked #164, and it fits the shape. The only other change from v0.4.0 is the version number in package.json and package-lock.json, so the v0.4.0 code review carries over unchanged. The overview now describes the Automatic and Scheduled sync modes and the merge of diverged branches the way the code does them, and this pull request correctly removes the registry copy.
One sentence in the overview is broader than the code, and it does not block this bump. It says "If both machines change the same prompt, the merge is aborted", but Git aborts only when the two edits overlap; edits to different lines of the same prompt merge cleanly (server/git.ts:137-150). @yannelli, "If both machines change the same lines of a prompt" would match the code in a later release.
Review data
- Artifact: git
https://github.com/yannelli/paseo-prompt-manager.git,f3af8cf5ba5a60523c02507aa17f52bd307fa7d0(tagv0.4.1), fromf6a724bf56b85adc42373ea68e2b6f46ce6d11b0(tagv0.3.0). NopluginPath. - Pin: both commits exist on the remote and are reachable from
main;v0.3.0andv0.4.1still point at them.paseo-plugin.jsonis at the root and unchanged (paseo-prompt-manager, requires Paseo>=0.11.0-beta.3). The record changes only the pin andreviewedAt, and deletes the registry overviewplugins/yannelli/prompt-manager.md. - Validation:
npm testpasses (143/143).node scripts/validate.ts --online --changedpasses: 210 records well-formed, 1 record matches its pinned artifact. - Extracted and inspected: v0.3.0, v0.4.0, and v0.4.1 exported and diffed locally. v0.3.0 to v0.4.1 is 18 files, +867/-89. v0.4.0 to v0.4.1 is the new
OVERVIEW.mdplus the version field inpackage.jsonandpackage-lock.json, nothing else. The v0.3.0 to v0.4.0 code change, reviewed in #164, addsserver/sync.ts(sync scheduler withmanual,changes, andintervalmodes) andclient/sync.tsx(status badge and mode picker);server/git.tsnow merges instead of fast-forward only and can change or removeorigin.paseo-plugin.json,scripts/,.github/, anddocs/are unchanged. - Install-time commands: none.
paseo-plugin.jsonhas noinstallorbuild.package.jsonhas nopreinstall,install,postinstall, orprepare; its scripts aretypecheck,test,check, andrelease:dry-run. - Dependencies: no runtime
dependencies; dev dependencies unchanged.package-lock.jsonhas 317 entries, eachresolvedon registry.npmjs.org with anintegrity, andnpm ci --ignore-scriptsinstalls it. The only entry with an install script is the optional macOS dev dependencyfsevents. - Hosts: no hard-coded hosts and no
fetchor HTTP client. Network traffic is Git to theoriginthe user configures:ls-remote --symref origin HEAD(server/git.ts:74), andls-remote,fetch, andpush(server/git.ts:160-165), which run on a schedule only when the user picks a non-manual mode. - Credentials and environment:
GIT_SSH_COMMAND, defaulted tossh -o BatchMode=yes, plusGIT_TERMINAL_PROMPT=0, so sync never prompts (server/git.ts:27);XDG_CONFIG_HOME(server/library.ts:16). Git uses the host's existing Git credentials, which is what Git sync needs. - Filesystem: the settings file
prompt-manager.jsonunder the Paseo config directory and the prompt library directory, into which merges bring files fromorigin. Imports read only the paths the user selects. - Execution:
execFile("git", ["-c", "core.hooksPath=/dev/null", ...])(server/git.ts:24-28), so repository hooks never run. Subcommands added in v0.4.0:remote set-url,remote remove origin,branch -m,symbolic-ref, andmerge --no-edit FETCH_HEADwithmerge --aborton failure. Automatic sync runs only when Git sync is enabled and the mode is not manual (server/sync.ts:39-72). Noeval,new Function, or dynamicimport(). - Runtime installs: none.
- Source match: git artifact; all
.tsand.tsxfiles are readable source, with no bundles or minified files. - Listing media: six PNGs pinned to
f6a724bf, each HTTP 200image/pngand byte-identical at v0.4.1. - Overview:
OVERVIEW.mdis present and follows the shape: what it is, setup, Git sync, what it reads and sends, known limits; no install steps, badges, changelog, or license. Checked against the code: the three modes with the 5 second debounce and the 5, 15, 30, and 60 minute choices, sync on library open, merge of diverged branches with abort on conflict, changing the URL or branch and removingoriginwhen the URL is cleared, no password prompts, hooks disabled, the settings and library paths, and the import limits (100 files, 8 MB, 512 KB per file, 5,000 entries). The only imprecise sentence is the one noted above. The registry copy is deleted in this pull request. - Decision: merge.
- Reviewed commit:
2f7cb44a5679f2f1917e048e334eddd869fa2812
yannelli/prompt-manager: {"kind":"git","remote":"https://github.com/yannelli/paseo-prompt-manager.git","commit":"f6a724bf56b85adc42373ea68e2b6f46ce6d11b0","tag":"v0.3.0"} -> {"kind":"git","remote":"https://github.com/yannelli/paseo-prompt-manager.git","commit":"f3af8cf5ba5a60523c02507aa17f52bd307fa7d0","tag":"v0.4.1"}Git tag
v0.4.1pins commitf3af8cf5ba5a60523c02507aa17f52bd307fa7d0.Original submitter is not recorded; refer to the source owner.
Merging approves this version. The published index keeps pointing at the previous one until then.
Artifact diff (truncated; the full diff is in the workflow artifact)
This version ships OVERVIEW.md, so the registry's copy is removed in this bump.
Inline validation passed:
npm testand the checks fromnode scripts/validate.ts --online --changed. The default GITHUB_TOKEN does not trigger the PR validation workflow.