Repository navigation
Bump yannelli/prompt-manager to v0.4.0 - #164
github-actions[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Needs from you: nothing, changes requested
@yannelli, this bump can't merge yet: Prompt Manager v0.4.0 has no OVERVIEW.md, and the registry needs one for every new version.
Change needed: add OVERVIEW.md next to paseo-plugin.json in https://github.com/yannelli/paseo-prompt-manager, tag a new release, and the bump workflow will open a fresh pull request for it. Your file replaces the registry copy, plugins/yannelli/prompt-manager.md. You can start from that copy without its last "imported from paseo.cafe" line, but two of its statements no longer hold for v0.4.0:
- It says sync runs only when you choose Sync now. In v0.4.0 the Automatic and Scheduled modes sync on their own (5 seconds after a change, or every chosen interval) and also when the library is opened.
- It says sync stops when the remote branch has diverged. v0.4.0 merges diverged branches and stops only on a merge conflict.
Also worth covering: the remote URL and branch can be changed later, clearing the URL removes origin, and background sync needs a credential helper or SSH agent because it never prompts for a password.
The shape is in REVIEW.md, in this order: what the plugin is and does; how it works, if needed; setup (Paseo 0.11.0-beta.3 or newer, a Git remote for sync); then what it reads or sends and where, its settings, and known limits. Leave out installation steps, badges, changelog, and license sections.
The code change in v0.4.0 is fine. Nothing else needs to change.
Review data
- Artifact: git
https://github.com/yannelli/paseo-prompt-manager.git,2338a9a605f2aaa2412f5ec73f4ae735747f3984(tagv0.4.0), fromf6a724bf56b85adc42373ea68e2b6f46ce6d11b0(tagv0.3.0). NopluginPath. - Pin: both commits exist on the remote, and
v0.3.0andv0.4.0still point at them.paseo-plugin.jsonis at the root and unchanged (paseo-prompt-manager, requires Paseo>=0.11.0-beta.3). - Validation:
npm testpasses (140/140).node scripts/validate.ts --online --changedfails with one error:yannelli/prompt-manager/OVERVIEW.md is required. - Extracted and inspected: both commits exported and diffed locally, 17 files, +827/−89. New
server/sync.ts(sync scheduler withmanual,changes, andintervalmodes),client/sync.tsx(sync status badge and mode picker);server/git.tsnow merges instead of fast-forward only and can change or removeorigin; prompt-list cache and composer search debounce.paseo-plugin.json,scripts/, and.github/are unchanged. - Install-time commands: none.
paseo-plugin.jsonhas noinstallorbuild.package.jsonhas nopreinstall,install,postinstall, orprepare; its scripts aretypecheck,test,check, andrelease:dry-run. - Dependencies: no runtime
dependencies; dev dependencies unchanged.package-lock.jsonhas 317 entries, eachresolvedon registry.npmjs.org with anintegrity, andnpm ci --ignore-scriptsinstalls it. The only entry with an install script is the optional macOS dev dependencyfsevents. The lockfile diff is the version field only. - Hosts: no hard-coded hosts and no
fetchor HTTP client. Network traffic is Git to theoriginthe user configures:ls-remote --symref origin HEADis new (server/git.ts:74);fetch,ls-remote, andpush(server/git.ts:160-165) can now run on a schedule the user picks. - Credentials and environment:
GIT_SSH_COMMAND, defaulted tossh -o BatchMode=yesso background sync never prompts (server/git.ts:27), is new;XDG_CONFIG_HOME(server/library.ts:16) is existing. Git uses the host's existing Git credentials, which is what Git sync needs. - Filesystem: no new paths. Writes its settings file under the Paseo config directory (now also
syncModeandsyncInterval) and the prompt library directory, into which merges now bring files fromorigin. - Execution:
execFile("git", ["-c", "core.hooksPath=/dev/null", ...])as before (server/git.ts:26-27), so repository hooks never run. New Git subcommands:remote set-url,remote remove origin(server/git.ts:94-95),branch -m,symbolic-ref, andmerge --no-edit FETCH_HEADwithmerge --aborton failure (server/git.ts:137-150). Automatic sync runs only when Git sync is enabled and the user has chosen a non-manual mode (server/sync.ts:39-74). Noeval,new Function, or dynamicimport(). - Runtime installs: none.
- Source match: git artifact; all
.tsand.tsxfiles are readable source, with no bundles or minified files. - Listing media: six PNGs pinned to
f6a724bf, each HTTP 200image/pngand byte-identical at v0.4.0. - Overview: missing at the pinned commit. The registry copy describes v0.3.0's manual-only, fast-forward-only sync, as listed above.
- Decision: changes requested, because
OVERVIEW.mdis missing. - Reviewed commit:
9ef19d91b920ff9c41dff384077788100b1546bd
|
Closing this obsolete bump: PR #179 already published Prompt Manager v0.4.1. Nothing is needed from you for v0.4.0. The earlier requirement to release solely for an overview is superseded by the current policy, which permits a registry overview. Review data
|
yannelli/prompt-manager: {"kind":"git","remote":"https://github.com/yannelli/paseo-prompt-manager.git","commit":"f6a724bf56b85adc42373ea68e2b6f46ce6d11b0","tag":"v0.3.0"} -> {"kind":"git","remote":"https://github.com/yannelli/paseo-prompt-manager.git","commit":"2338a9a605f2aaa2412f5ec73f4ae735747f3984","tag":"v0.4.0"}Git tag
v0.4.0pins commit2338a9a605f2aaa2412f5ec73f4ae735747f3984.Original submitter is not recorded; refer to the source owner.
Merging approves this version. The published index keeps pointing at the previous one until then.
Artifact diff (truncated; the full diff is in the workflow artifact)
This version has no OVERVIEW.md. The registry requires one to update a listing; the bump cannot merge until the repository adds it.
Inline validation failed. See the Bump workflow log.