Repository navigation
Move the format crates from plugins/ to crates/formats/ - #456
Merged
Merged
Conversation
Since #437 the server links in every format, so plugins/ was only a second directory of workspace crates. NuGet and raw now live in crates/formats/<id>/, with the same crate names and code, and plugins/README.md is crates/formats/README.md. The workspace members, the path dependencies on the format crates and theirs on forge-plugin-api, and the NuGet fixture path follow the new depth. The CI change filter, CodeQL's language filter and its comment no longer name plugins/ (crates/ covers the new place), and .dockerignore drops the target directory of a crate built on its own, which no crate has now. AGENTS.md's rule on formats, README.md, DEVELOPMENT.md, the format docs, the module docs and the expect messages name crates/formats/<id>. Fixes #443 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CxwRK8xYPsMDBiMkySxcHf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443
Part of #442. Since #437 the server links in every format, so
plugins/was only a second directory of workspace crates. NuGet and raw now live incrates/formats/<id>/. The crate names (forge-format-nuget,forge-format-raw) and their code are unchanged, andplugins/README.mdis nowcrates/formats/README.md.Changes
git mv plugins/<id> crates/formats/<id>fornugetandraw.plugins/is gone.members;crates/core,crates/e2eandcrates/server(now../formats/<id>);forge-plugin-api(../../plugin-api);tests/parse.rs, which readsfixtures/nugetfrom one level deeper.ci-changes.shand thetouchescheck incodeql.ymlno longer nameplugins, sincecratescovers the new place;codeql-config.ymlnow namescrates/formats/*/tests;.dockerignoredrops/plugins/*/target. That ignore existed for crates built on their own target dir; every format crate now builds into the workspace's/target..gitignorehad no such line.crates/formats/<id>:AGENTS.mdsection, now Formats: every format lives under crates/formats/, which also no longer says raw still has to move (it moved in Raw repositories as a built-in format plugin over a host file store #441);README.md(the crate table and the formats paragraph);DEVELOPMENT.md(the formats section and the Rust paths in the CI and CodeQL tables);docs/format-plugins.md,docs/raw.mdandcrates/formats/README.md, including their relative links;forge-plugin,forge-plugin-api,forge-coreandforge-server;expectmessages that namedplugins/<id>/plugin.toml;fixtures/nuget/make_fixtures.py.DEVELOPMENT.md's CI table listed apluginsjob, whichci.ymlno longer has. I dropped it along with theplugins/path.No changelog fragment, since nothing changes for anyone running Forge.
Checks
cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warningspass..github/scripts/test-parallel.sh --workspace: 104 of 105 test binaries passed, including NuGet's fixture tests from the new path. The exception wasforge-core'sproxy_read, wherepackage_delay_hides_then_revealschecks a 1-second package-delay window and the binary took 28 s under the parallel load. Run alone, it passes 50/50 in 8 s. No proxy code changed here.git grepfinds no path into the oldplugins/directory outsideCHANGELOG.mdanddocs/changes/.Generated by Claude Code