Repository navigation
Move the Docker / OCI crate to crates/formats/docker - #461
Merged
Merged
Conversation
crates/format-oci (forge-oci) is now crates/formats/docker (forge-format-docker), next to the other format crates, as it is: the registry stays native, served by crate::registry under /v2, not a FormatPlugin. forge_oci:: becomes forge_format_docker:: in forge-server and its tests; the crate's path dependencies, the workspace members and forge-server's dependency follow the move. AGENTS.md, README.md, DEVELOPMENT.md, crates/formats/README.md and docs/format-plugins.md say that Docker / OCI is in crates/formats/docker and still native; the AGENTS.md rule keeps saying it is not the model for a new format until it implements FormatPlugin. Fixes #445 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CxwRK8xYPsMDBiMkySxcHf
# Conflicts: # Cargo.lock # DEVELOPMENT.md # README.md # crates/server/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445
Part of #442. #456 (#443) and #458 (#444) have merged, and this PR now targets
main.mainis merged in: #460 changed the old crate's files (ActionbecameLevel), and git carried those changes intocrates/formats/docker.Changes
git mv crates/format-oci crates/formats/docker. The crate is renamed fromforge-ocitoforge-format-docker, like the crates next to it.forge_oci::becomesforge_format_docker::inforge-serverand its tests (admin.rs,registry.rs).../../coreand the rest);members, now grouping the three format crates;forge-server's dependency on it.crate::registryserves it under/v2, not as aFormatPlugin.crates/formats/dockerand still native:AGENTS.md(its rule still says the crate is not the model for a new format until it implementsFormatPlugin);README.md(the crate table and the formats paragraph);DEVELOPMENT.md;crates/formats/README.md;docs/format-plugins.md.No changelog fragment, since nothing changes for anyone running Forge.
Checks
cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warningspass, before and after mergingmain..github/scripts/test-parallel.sh --workspacepasses, includingcrates/server/tests/registry.rs. A first run failed because the disk filled up: containers from earlier runs had piled up. The rerun on a clean disk passed every binary.main:registry(32 tests),admin(45) andbrowse(10) pass, andcargo xtask changelog --checkpasses.git grep -n 'format-oci\|forge-oci\|forge_oci'finds nothing outsideCHANGELOG.mdanddocs/changes/.oci-e2eanddockerrun in CI now that this targetsmain. Make Docker / OCI a format plugin over a host image store #462, which builds on this PR, passedoci-e2elocally.Generated by Claude Code