Skip to content

[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: time_picker_test #13471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Oct 29, 2026
Merged

[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: time_picker_test #13471

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef62b3
[material_ui] Unskip web tests in time_picker_test
harryterkelsen Oct 28, 2026
a0389f2
[material_ui] Explain why time picker restoration tests are skipped o…
harryterkelsen Oct 28, 2026
deef901
[material_ui] Mark time picker restoration web skip as intended
harryterkelsen Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/material_ui/test/time_picker_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// This file is run as part of a reduced test set in CI on Mac and Windows
// machines.
@Tags(<String>['reduced-test-set'])
@TestOn('!chrome')
library;

import 'dart:async';
Expand Down Expand Up @@ -2354,6 +2353,10 @@ void main() {
);
});

// Skipped on the web because routes pushed with Navigator.restorablePush
// (used by _TimePickerLauncher) are not restorable there: the framework
// can't serialize the route builder without PluginUtilities, so the
// picker dialog is gone after restartAndRestore.
group('Time picker - Restoration (${materialType.name})', () {
testWidgets('Time Picker state restoration test - dial mode', (WidgetTester tester) async {
TimeOfDay? result;
Expand Down Expand Up @@ -2461,7 +2464,7 @@ void main() {
await finishPicker(tester);
expect(result, equals(const TimeOfDay(hour: 6, minute: 45)));
});
});
}, skip: kIsWeb); // [intended] PluginUtilities is not supported on the web.

group('Time picker - emptyInitialInput (${materialType.name})', () {
testWidgets('Fields are empty and show correct hints when emptyInitialInput is true', (
Expand Down
Loading