Repository navigation
[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: time_picker_test - #13471
Open
harryterkelsen wants to merge 2 commits into
Open
harryterkelsen wants to merge 2 commits into
harryterkelsen wants to merge 2 commits into
Conversation
harryterkelsen
marked this pull request as ready for review
October 28, 2026 21:02
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the '@teston("!chrome")' annotation from the time_picker_test.dart file and instead skips the 'Time picker - Restoration' test group on the web using 'skip: kIsWeb', adding an explanatory comment. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
@TestOn('!chrome')annotation frompackages/material_ui/test/time_picker_test.dartso that its tests run on the web. All 190 tests in the file now pass on Chrome under both CI web renderers (CanvasKit with dart2js and Skwasm with dart2wasm). The time picker state restoration group still does not work on the web, so it is now skipped individually withskip: kIsWebinstead of skipping the whole file.Part of flutter/flutter#33615 (the state restoration group remains skipped on web pending that issue).
This is a test-only change, so it is exempt from version and CHANGELOG updates.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2