Skip to content

[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: time_picker_test - #13471

Open
harryterkelsen wants to merge 2 commits into
flutter:mainfrom
harryterkelsen:unskip-web-tests-in-packages-material-ui-test-4
Open

harryterkelsen wants to merge 2 commits into
flutter:mainfrom
harryterkelsen:unskip-web-tests-in-packages-material-ui-test-4

Conversation

@harryterkelsen

@harryterkelsen harryterkelsen commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Removes the @TestOn('!chrome') annotation from packages/material_ui/test/time_picker_test.dart so that its tests run on the web. All 190 tests in the file now pass on Chrome under both CI web renderers (CanvasKit with dart2js and Skwasm with dart2wasm). The time picker state restoration group still does not work on the web, so it is now skipped individually with skip: kIsWeb instead of skipping the whole file.

Part of flutter/flutter#33615 (the state restoration group remains skipped on web pending that issue).

This is a test-only change, so it is exempt from version and CHANGELOG updates.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Oct 28, 2026
@harryterkelsen
harryterkelsen marked this pull request as ready for review October 28, 2026 21:02
@harryterkelsen harryterkelsen added the CICD Run CI/CD label Oct 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the '@teston("!chrome")' annotation from the time_picker_test.dart file and instead skips the 'Time picker - Restoration' test group on the web using 'skip: kIsWeb', adding an explanatory comment. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant