Skip to content

[tool] Exempt AGENTS.md from version and changelog checks - #12681

Open
reidbaker-agent wants to merge 1 commit into
flutter:mainfrom
reidbaker:exempt-agents-md-from-version-checks
Open

[tool] Exempt AGENTS.md from version and changelog checks#12681
reidbaker-agent wants to merge 1 commit into
flutter:mainfrom
reidbaker:exempt-agents-md-from-version-checks

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This came up as part of #12668 which needed the labels. This pr excludes AGENTS.md from both pub publishing and from needing changelog/version requirements.

Agent authored description

Exempts AGENTS.md from requiring CHANGELOG updates and version bumps in package validation, adds AGENTS.md as a package support file in repo tooling, and adds AGENTS.md to .pubignore in camera_android_camerax.

Summary

  • Repository Tooling:
    • script/tool/lib/src/common/package_state_utils.dart: Added pathComponents.last == 'AGENTS.md' to _isDevChange so developer/agent guidelines in AGENTS.md do not trigger missing CHANGELOG or version bump errors.
    • script/tool/lib/src/common/file_filters.dart: Added path.endsWith('/AGENTS.md') to isPackageSupportFile.
    • script/tool/CHANGELOG.md: Added changelog entry under ## NEXT.
  • Package .pubignore:
    • packages/camera/camera_android_camerax/.pubignore: Added AGENTS.md to prevent publishing agent guidelines to pub.dev.
  • Tests:
    • Added unit tests in script/tool/test/common/package_state_utils_test.dart, script/tool/test/common/file_filters_test.dart, and script/tool/test/validate_command_version_test.dart.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed features or bug fixes.
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The title of the PR starts with the name of the package and conforms to the style guide.

Exempts AGENTS.md from triggering missing CHANGELOG and version bump errors in flutter_plugin_tools validate, adds AGENTS.md as a package support file, and adds it to .pubignore in camera_android_camerax.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exempts AGENTS.md from requiring version and changelog changes by updating file filters and package state utilities to recognize it as a package support and dev-facing file. It also adds corresponding unit tests and updates .pubignore for the camera_android_camerax package. There are no review comments, and I have no feedback to provide.

@reidbaker
reidbaker requested a review from camsim99 August 28, 2026 19:41
@reidbaker reidbaker added the CICD Run CI/CD label Aug 28, 2026
@reidbaker
reidbaker marked this pull request as draft August 28, 2026 19:41
@reidbaker

Copy link
Copy Markdown
Contributor

Convert to draft until tests pass.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exempts AGENTS.md files from requiring version and changelog changes. It updates the tooling to recognize AGENTS.md as a package support file and a dev-facing change, and adds corresponding unit tests to verify this behavior. There are no review comments to address.

@reidbaker reidbaker added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 28, 2026
@reidbaker

Copy link
Copy Markdown
Contributor

Ironically the labels are needed on this pr because pubignore is not an excluded file. I think that is correct because if the ignore changes caused added files for a release then you probably do want a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants