Skip to content

[camera_android_camerax] Add presubmit sweep, cross-platform paths, and test diff guidelines to AGENTS.md - #12668

Merged
reidbaker merged 3 commits into
flutter:mainfrom
reidbaker:update-agents-md-guidelines
Aug 28, 2026
Merged

[camera_android_camerax] Add presubmit sweep, cross-platform paths, and test diff guidelines to AGENTS.md#12668
reidbaker merged 3 commits into
flutter:mainfrom
reidbaker:update-agents-md-guidelines

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

These suggestions came from /learn. No evals because the infra required to test the actually valuable one requires interactions with remote services. I am going to brainstorm on how we can/should evaluate remote interactions.

http://github.com/flutter/packages/pull/12681 is a pr that will not required the override labels for prs like this.


Agent authored description

Description

Adds key agent guidelines to camera_android_camerax/AGENTS.md:

  • Presubmit Sweep Fixes: Directs agents to wait until all builder targets in the presubmit matrix complete before pushing, reproducing and fixing all failures locally to push in one consolidated commit.
  • Cross-Platform Paths in Tests: Enforces constructing CLI arguments and file paths with package:path (p.join / p.joinAll) rather than hardcoded / to avoid test failures on Windows CI bots.
  • Preserve Test Order: Directs agents to maintain the original sequence of existing unit tests when adding or updating tests to minimize review diffs.

Tests

  • Validated flutter test test/skills_evals_test.dart test/validate_skills_test.dart (all passing).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AGENTS.md file in the camera_android_camerax package by adding guidelines for presubmit sweep fixes, cross-platform paths in tests, and preserving test order. The feedback suggests clarifying that the cross-platform path guideline applies to local file system paths and not to Flutter asset paths, package URIs, or URLs, which must always use forward slashes.

Comment thread packages/camera/camera_android_camerax/AGENTS.md Outdated
@reidbaker
reidbaker requested a review from camsim99 August 28, 2026 14:36
@reidbaker reidbaker added the CICD Run CI/CD label Aug 28, 2026
@reidbaker reidbaker added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 28, 2026
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2026
@auto-submit

auto-submit Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12668, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@reidbaker
reidbaker self-requested a review August 28, 2026 20:05
@reidbaker
reidbaker merged commit 7c01c0b into flutter:main Aug 28, 2026
14 checks passed
@reidbaker
reidbaker deleted the update-agents-md-guidelines branch August 28, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants