[camera_android_camerax] Add presubmit sweep, cross-platform paths, and test diff guidelines to AGENTS.md - #12668
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AGENTS.md file in the camera_android_camerax package by adding guidelines for presubmit sweep fixes, cross-platform paths in tests, and preserving test order. The feedback suggests clarifying that the cross-platform path guideline applies to local file system paths and not to Flutter asset paths, package URIs, or URLs, which must always use forward slashes.
5 tasks
camsim99
approved these changes
Aug 28, 2026
Contributor
|
autosubmit label was removed for flutter/packages/12668, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
reidbaker
self-requested a review
August 28, 2026 20:05
reidbaker
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These suggestions came from /learn. No evals because the infra required to test the actually valuable one requires interactions with remote services. I am going to brainstorm on how we can/should evaluate remote interactions.
http://github.com/flutter/packages/pull/12681 is a pr that will not required the override labels for prs like this.
Agent authored description
Description
Adds key agent guidelines to
camera_android_camerax/AGENTS.md:package:path(p.join/p.joinAll) rather than hardcoded/to avoid test failures on Windows CI bots.Tests
flutter test test/skills_evals_test.dart test/validate_skills_test.dart(all passing).