Repository navigation
Record the plugin digest once, at release - #171
Merged
Merged
Conversation
Every packaged edit had to re-pack the plugin with the exact CLI and commit a new plugin_source.tarball_sha256, because CI compared its pack with the committed digest at every pull request head. One Skills pull request ran the pack four to seven times, and every review had to check the digest. The digest now changes once per release. The service's script/release ship packs the main commit it smoked, commits only the new digest on it as a fast-forward of main, waits for that commit's CI, and tags it. CI compares its own pack with the committed digest only in a change that edits it, or when it cannot read the base, so the tagged commit's CI still checks the bytes the tag publishes. The publish workflow and the service's verify compare again, unchanged, and the release-compatibility format keeps its required digest. The Docs line check now skips catalog selections. Review follows risk tiers, with one high-effort round for packaged Skill text, and the Review line records the verdict and counts instead of a session id that names a deleted worktree.
raghubetina
force-pushed
the
record-digest-at-release
branch
from
October 12, 2026 15:13
894c53d to
8a036e8
Compare
raghubetina
marked this pull request as ready for review
October 12, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every packaged edit had to re-pack the plugin with the exact CLI and commit a new
plugin_source.tarball_sha256, because CI compared its pack with the committed digest at every pull request head. Tonight that meant four to seven packs per Skills pull request, and every review had to check the digest.The digest now changes once per release. The service's
script/release shippacks themaincommit it smoked, commits only the new digest on it as a fast-forward ofmain(it refuses ifmainmoved, and checks that the commit changes nothing but that field), waits for that commit's CI, and tags it. CI compares its own pack with the committed digest only in a change that edits it, or when it cannot read the base, so the tagged commit's CI still checks the bytes the tag publishes. The publish workflow's "Verify publication bytes" step and the service'sverifycompare again, unchanged. Thefirstdraft.release-compatibility/1format keeps its required digest, so no format changes.Also, from the same owner-approved process change (2026-10-12): the Docs line check skips catalog selections; review follows risk tiers, with one high-effort round for packaged Skill text and none for mirror text, pins, catalog selections, or digest records; and the
Review:line records the verdict and counts instead of a session id that names a deleted worktree.Lands with firstdraft/firstdraft's
script/release shippull request and firstdraft/cli'sReview:line pull request. This change alone keeps every release working: untilshipexists, a release records the digest by hand as RELEASING.md §2 now says.Review: Codex, approve (2 rounds at max effort, 1 finding fixed)
Docs: updated RELEASING.md §2–4 and "Reproduce CI locally", AGENTS.md "Checks and review", CONTRIBUTING.md, and the PR template; the service's RELEASE_COORDINATION.md and CONTRIBUTING.md change in the companion pull request.