Repository navigation
Record review verdicts and counts, not sessions - #57
Merged
Merged
Conversation
The Review line named a cross-review session id. That id names a file in the authoring worktree, which is deleted after merge, so no reader could open it. The service, Skills, and CLI now record the reviewer, the verdict, and the finding counts instead, and a material finding gets one line in the commit message, where git blame keeps it. The three CONTRIBUTING pages share this rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Review:line named a cross-review session id. That id names a file in the authoring worktree, which is deleted after merge, so no reader could open it. The service, Skills, and CLI now record the reviewer, the verdict, and the finding counts instead (for exampleReview: Codex, approve (2 rounds, 3 findings fixed)), and a material finding gets one line in the commit message. The three CONTRIBUTING pages share this rule; firstdraft/skills#171 and the service'sscript/release shippull request change their copies.Review: Codex, approve (1 round, no findings; high effort, instruction-policy change only)
Docs: updated AGENTS.md, CONTRIBUTING.md, and the PR template; the Skills and service copies change in their companion pull requests.
Validation
npm audit: not rerun; no dependency changenpm run check: passed