Skip to content

Record review verdicts and counts, not sessions #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raghubetina merged 1 commit into from
Oct 12, 2026
Merged

Record review verdicts and counts, not sessions #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Docs: <!-- "updated <files>" or "none, because ..." -->

<!--
When AGENTS.md requires independent review, add one line and leave the findings out:
Review: <reviewer>, session <id>, <verdict>
Review: <reviewer>, <verdict> (<rounds> rounds, <fixed> findings fixed)

Add no agent attribution, such as a "Generated with" line.
-->
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ handled-error recovery in `docs/errors.md`, publication mechanics in `RELEASING.
exit statuses, `AGENTS.md`, `CLAUDE.md`, `CONTRIBUTING.md`, `RELEASING.md`, `.claude/settings.json`, or
`.codex/config.toml` get an independent review through cross-review: `codex-review` from Claude Code,
`$claude-review` from Codex. Pass the service repository's `docs/review-focus.md` as `--focus-file` (see
`CONTRIBUTING.md`). Put the reviewer, session id, and verdict in the pull request body, and leave the findings out.
`CONTRIBUTING.md`). Put the reviewer, verdict, and finding counts in the pull request body, not the findings.
- `firstdraft plan compile` defaults to local output in the current directory. GitHub publication requires
`--github`; Codespaces is a fallback. Keep Skill callers and recovery instructions aligned with this boundary.
- The service repository coordinates releases and owns their approval and smoke policy. One approved coordinated
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ that a bot such as Dependabot opens.
The body also carries:

- a summary of what changed and why; and
- when [AGENTS.md](AGENTS.md) requires independent review, one line, `Review: <reviewer>, session <id>, <verdict>`,
with the findings left out.
- when [AGENTS.md](AGENTS.md) requires independent review, one line with the reviewer, the verdict, and the counts,
such as `Review: Codex, approve (2 rounds, 3 findings fixed)`. Leave out session ids, which name files in a deleted
worktree, and the findings themselves; give a material finding one line in the commit message.

Use GitHub closing keywords only for completed Issues: even `does not close #123` closes #123. Say the remainder is
tracked in open Issue #123 instead. The [pull request template](.github/pull_request_template.md) holds these fields.
Expand Down
Loading