Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
unreleased
==========

* Fix: a numeric timeout of `0` was treated as the 5000ms default
because `time || 5000` is falsy for zero

1.9.1 / 2025-07-17
==========

Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function timeout (time, options) {

var delay = typeof time === 'string'
? ms(time)
: Number(time || 5000)
: Number(time == null ? 5000 : time)

var respond = opts.respond === undefined || opts.respond === true

Expand Down
7 changes: 7 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ describe('timeout()', function () {
.expect(503, /123ms/, done)
})

it('should accept a zero millisecond timeout', function (done) {
var server = createServer(0)
request(server)
.get('/')
.expect(503, /after 0ms/, done)
})

it('should accept string timeout', function (done) {
var server = createServer('45ms')
request(server)
Expand Down