Honor a numeric timeout of 0 instead of using the 5000ms default - #90
Open
official-burak wants to merge 1 commit into
Open
Honor a numeric timeout of 0 instead of using the 5000ms default#90official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
time || 5000 is falsy for zero, so timeout(0) waited five seconds. timeout("0ms") already meant zero milliseconds.
kilisamemarisaaa
left a comment
kilisamemarisaaa
left a comment
There was a problem hiding this comment.
Reviewed the numeric-zero fix on commit 8cf5a72. The change preserves the documented default for omitted/null time while allowing an explicit numeric 0 to schedule an immediate timeout. Verification on Windows with Node 24.12.0: npm test (14 passing), npm run lint (pass), plus a direct middleware check confirming undefined/null -> 5000ms and 0 -> 0ms. I found no correctness issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timeout(0)waited five seconds becausetime || 5000is falsy for zero.timeout("0ms")already meant zero milliseconds.The default when
timeis omitted or null is still 5000ms.