Skip to content

ci(release): drop expired ETHER_RELEASE_TOKEN fallback #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
Oct 19, 2026
+6 −8
Merged

ci(release): drop expired ETHER_RELEASE_TOKEN fallback #8361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ jobs:
releases:
runs-on: ubuntu-latest
steps:
# Prefer a short-lived token from the "Etherpad Release Bot" GitHub App:
# app credentials don't expire, unlike the ETHER_RELEASE_TOKEN PAT. Until
# the RELEASE_APP_ID variable is set this step is skipped and the PAT is
# used. The built-in GITHUB_TOKEN won't do: tags pushed with it don't
# trigger the Docker, .deb, snap and GitHub Release workflows.
# Short-lived token from the "etherpad-release-bot" GitHub App; app
# credentials don't expire like a PAT does. The built-in GITHUB_TOKEN
# won't do: tags pushed with it don't trigger the Docker, .deb, snap and
# GitHub Release workflows.
- name: Get release token from GitHub App
id: app-token
if: vars.RELEASE_APP_ID != ''
uses: actions/create-github-app-token@v2
with:
app-id: ${{ vars.RELEASE_APP_ID }}
Expand All @@ -40,7 +38,7 @@ jobs:
with:
repository: ether/etherpad
path: etherpad
token: ${{ steps.app-token.outputs.token || secrets.ETHER_RELEASE_TOKEN }}
token: ${{ steps.app-token.outputs.token }}
fetch-depth: '0'
fetch-tags: 'true'
- name: Checkout master
Expand All @@ -60,7 +58,7 @@ jobs:
with:
repository: ether/ether.github.com
path: ether.github.com
token: ${{ steps.app-token.outputs.token || secrets.ETHER_RELEASE_TOKEN }}
token: ${{ steps.app-token.outputs.token }}
- uses: actions/cache@v6
name: Cache pnpm store
with:
Expand Down
Loading