ci(release): drop expired ETHER_RELEASE_TOKEN fallback

[JohnMcLear]

Follow-up to #8359. 3.3.9 shipped using the etherpad-release-bot GitHub App token, and the old ETHER_RELEASE_TOKEN PAT secret has now been deleted.

This removes the dead || secrets.ETHER_RELEASE_TOKEN fallback from both checkouts. It also drops the if: vars.RELEASE_APP_ID != '' guard, so a missing app config fails at the token step instead of silently checking out with no token.

Tests: workflow YAML parses. The release itself is only exercised on the next dispatch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Y5YroE8t1VhXCVTjJhx2kU

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Require GitHub App authentication for releases

⚙️ Configuration changes 🕐 Less than 10 minutes

AI Description

• Remove the deleted PAT fallback from both release-workflow checkouts.
• Require GitHub App token creation so missing app configuration fails before checkout.

Diagram

graph TD
  A["Release dispatch"] --> B["Create app token"] --> C["Checkout repositories"] --> D["Prepare and push"] --> E["Downstream workflows"]
  B --> F["Fail if unconfigured"]

Loading

High-Level Assessment

Use the GitHub App token as the sole release credential. The deleted PAT cannot serve as a fallback, and the built-in GITHUB_TOKEN does not trigger the downstream workflows required by the release.

Files changed (1) +6 / -8

Other (1) +6 / -8

release.ymlRequire an app token for both release checkouts +6/-8

Require an app token for both release checkouts

• Removes the condition that skipped GitHub App token creation and the deleted PAT fallback from both checkout steps. Updates the workflow comment to describe the app token as the required release credential.

.github/workflows/release.yml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can import rules and skills only from the repositories your team follows

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗