Conversation
In `test_poll_blocking_asyncify.c`, `emscripten_set_timeout` was called before `clock_gettime(CLOCK_MONOTONIC, &begin)` in `test_unblock_poll`. Because Node.js schedules `setTimeout` relative to its internal millisecond-truncated timestamp (`binding.getLibuvNow()`), any delay or OS thread scheduling preemption between scheduling the timer and recording `begin` was subtracted from the measured duration. Record `begin` before calling `emscripten_set_timeout` (matching the pthread-based poll/select blocking tests), switch from hardcoded `1000`ms to `TIMEOUT_MS` (`300`ms, as done in emscripten-core#26257), normalize negative nanoseconds in `timespec_delta_ms`, and increase `TIMEOUT_MARGIN_MS` to `20`ms across all blocking poll/select tests. Fixes: emscripten-core#27727
guybedford
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
test_poll_blocking_asyncify.c,emscripten_set_timeoutwas called beforeclock_gettime(CLOCK_MONOTONIC, &begin)intest_unblock_poll. Because Node.js schedulessetTimeoutrelative to its internal millisecond-truncated timestamp (binding.getLibuvNow()), any delay or OS thread scheduling preemption between scheduling the timer and recordingbeginwas subtracted from the measured duration.Record
beginbefore callingemscripten_set_timeout(matching the pthread-based poll/select blocking tests), switch from hardcoded1000ms toTIMEOUT_MS(300ms, as done in #26257), normalize negative nanoseconds intimespec_delta_ms, and increaseTIMEOUT_MARGIN_MSto20ms across all blocking poll/select tests.Fixes: #27727