[test] Fix test_poll_blocking_asyncify flake: start the clock before arming the timer - #27728
Closed
guybedford wants to merge 1 commit into
Closed
guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
Collaborator
|
Ha, I guess our agents raced to fix this :) #27729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27727.
In
test_unblock_poll,emscripten_set_timeout(write_to_pipe, 1000)was armed beforeclock_gettime(&begin), so any delay between the two (preemption on a loaded CI machine, GC) shortens the measured duration below the timer's 1000 ms and trips the>= 1000 - TIMEOUT_MARGIN_MSassertion. The failing log shows exactly that: 994 ms against a 995 ms floor.Reproduced deterministically by inserting a 10 ms spin between the two calls (993 ms), and verified the reordering keeps the duration >= 1000 with the same spin in place.
The pthread variants (
test_poll_blocking.c,test_select_blocking.c,test_pselect_blocking.c) already takebeginbefore starting the delayed writer; this brings the asyncify variant in line.Made with AI assistance under my review