Skip to content

[test] Fix test_poll_blocking_asyncify flake: start the clock before arming the timer #27728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 1 commit into from
+4 −1
Closed

[test] Fix test_poll_blocking_asyncify flake: start the clock before arming the timer #27728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/core/test_poll_blocking_asyncify.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ void test_unblock_poll() {
{pipe_a[0], POLLIN, 0},
{pipe_shared[0], POLLIN, 0},
};
emscripten_set_timeout(write_to_pipe, 1000, NULL);
// Start the clock before arming the timer: any delay between the two (e.g.
// preemption on a loaded machine) would otherwise shorten the measured
// duration below the timer's.
clock_gettime(CLOCK_MONOTONIC, &begin);
emscripten_set_timeout(write_to_pipe, 1000, NULL);
assert(poll(fds, 2, -1) == 1);
clock_gettime(CLOCK_MONOTONIC, &end);
assert(fds[1].revents & POLLIN);
Expand Down
Loading