Repository navigation
Conversation
Signed-off-by: Don Yin <Don_Yin@outlook.com>
emancu
reviewed
Oct 31, 2026
| buffer | ||
| ) | ||
| else | ||
| status = %{status | opts: Keyword.delete(status.opts, :password)} |
There was a problem hiding this comment.
Thanks for this!
💡 One suggestion: the password is not the only secret in the connect state. status.ssl can hold the client private key and its passphrase, and status.opts also has the username, hostname and database, which DBConnection treats as sensitive.
Suggested change
| status = %{status | opts: Keyword.delete(status.opts, :password)} | |
| status = Map.drop(status, [:opts, :ssl]) |
Member
|
THank you, I pushed a fix based on this one. The test made the bug something we assert on, and if we fix that in other ways, then the test is wrong, so I went with a simpler fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connect state keeps the password in
optsafter authentication, so when the NotificationResponse in #806 crashes the connection, the MatchError puts the password in the crash log. I drop the password once authentication succeeds and left the notification crash itself alone. Fixes the second point of #806.