Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After authentication succeeds, the connect state still holds
opts(password, username, hostname, database) andssl(this can hold the client private key and its passphrase). No code reads them after authentication. But a crash whose term contains the state puts all of them in the exit reason and in the logs, for example the MatchError in #806. This change drops both keys when authentication succeeds.The idea comes from #807, which removes only the password. The password is not the only secret in the state:
sslcan hold a private key, and DBConnection also treats the username, hostname and database as sensitive. Both keys are unused after authentication, so it is simpler to drop them than to remove secrets one by one.I used Claude to help with this PR. I reviewed and tested the code.
Closes the second point of #806.