Skip to content

chore: attribute the old macro bottleneck to the syn parse #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Veetaha merged 1 commit into from
Oct 2, 2026
Merged

chore: attribute the old macro bottleneck to the syn parse #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bon-macros/src/builder/builder_gen/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ impl BuilderGenCtx {
.collect::<Vec<_>>();

// Every item here is a single top-level item. We add the `allow`
// attributes to each of them directly. Previously this code converted
// the final token stream to string and parsed it to `syn::File`, which
// resulted in a significant performance hit. Ouch. Don't do that again!
// attributes to each of them directly. Previously this code parsed
// the final token stream into a `syn::File`, which resulted in a
// significant performance hit. Ouch. Don't do that again!
let other_items = [builder_decl, builder_impl]
.into_iter()
.chain(builder_derives)
Expand Down
Loading