chore: attribute the old macro bottleneck to the syn parse - #408
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The comment now accurately reflects the benchmark findings without changing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects a performance comment to accurately identify parsing into syn::File as the former bottleneck.
Changes:
- Removes the inaccurate claim that token-stream string conversion caused the significant slowdown.
- Clarifies that parsing the final token stream was responsible.
| File | Description |
|---|---|
bon-macros/src/builder/builder_gen/mod.rs |
Corrects the historical performance explanation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eager
to_string()of the macro output cost only about 1% of the compile time in our benchmarks. Thesyn::Fileparse was the actual bottleneck. This PR corrects the comment from #405.