Skip to content

Fix nightly test restore with Central Package Management #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosebyte wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −5
Open

Fix nightly test restore with Central Package Management #7721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/Microsoft.ML.NugetPackageVersionUpdater/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private static IDictionary<string, string> GetLatestPackageVersions()

private static void UpdatePackageVersion(string projectFiles, IDictionary<string, string> latestPackageVersions)
{
string packageReferencePath = "/Project/ItemGroup/PackageReference";
string packageVersionPath = "/Project/ItemGroup/PackageVersion";

var projectFilePaths = projectFiles.Split(";".ToCharArray(), StringSplitOptions.RemoveEmptyEntries);

Expand All @@ -59,16 +59,16 @@ private static void UpdatePackageVersion(string projectFiles, IDictionary<string
var csprojDoc = new XmlDocument();
csprojDoc.Load(projectFilePath);

var packageReferenceNodes = csprojDoc.DocumentElement.SelectNodes(packageReferencePath);
var packageVersionNodes = csprojDoc.DocumentElement.SelectNodes(packageVersionPath);

for (int i = 0; i < packageReferenceNodes.Count; i++)
for (int i = 0; i < packageVersionNodes.Count; i++)
{
var packageName = packageReferenceNodes.Item(i).Attributes.GetNamedItem("Include").InnerText;
var packageName = packageVersionNodes.Item(i).Attributes.GetNamedItem("Include").InnerText;

if (latestPackageVersions.ContainsKey(packageName))
{
var latestVersion = latestPackageVersions[packageName];
packageReferenceNodes.Item(i).Attributes.GetNamedItem("Version").InnerText = latestVersion;
packageVersionNodes.Item(i).Attributes.GetNamedItem("Version").InnerText = latestVersion;
Console.WriteLine($"Update packege {packageName} to version {latestVersion}.");
}
else
Expand Down
11 changes: 11 additions & 0 deletions test/NightlyBuildDependency.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@
<ItemGroup>
<!-- Versions below are just placeholder, will be updated during nighly build pipeline to latest package version
-->
<PackageVersion Include="Microsoft.ML" Version="4.0.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.Ensemble" Version="0.22.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.EntryPoints" Version="0.22.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.FastTree" Version="4.0.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.LightGbm" Version="4.0.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.Mkl.Components" Version="4.0.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.OnnxConverter" Version="0.22.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.OnnxTransformer" Version="4.0.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.Parquet" Version="0.22.0-preview.24378.1" />
<PackageVersion Include="Microsoft.ML.Recommender" Version="0.22.0-preview.24378.1" />

<PackageReference Include="Microsoft.ML" />
<PackageReference Include="Microsoft.ML.Ensemble" />
<PackageReference Include="Microsoft.ML.EntryPoints" />
Expand Down
1 change: 1 addition & 0 deletions test/TestFrameworkDependency.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<ItemGroup Condition="'$(ReferenceTypeForTestFramework)' == 'NuGet'">
<!-- Versions below are just placeholder, will be updated during nighly build pipeline to latest package version
-->
<PackageVersion Include="Microsoft.ML" Version="1.5.0-preview-28305-3" />
<PackageReference Include="Microsoft.ML" />
</ItemGroup>
</Project>
Loading