Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes address the restore issue and preserve expected nightly behavior.
Pull request overview
Fixes Central Package Management restore failures for nightly tests and the full solution while preserving nightly version replacement behavior.
Changes:
- Adds placeholder
PackageVersionentries for nightly and test framework dependencies. - Updates the nightly package version updater to modify
PackageVersionitems.
File summaries
| File | Description |
|---|---|
test/TestFrameworkDependency.props |
Adds the Microsoft.ML placeholder version. |
test/NightlyBuildDependency.props |
Adds placeholder versions for nightly dependencies. |
test/Microsoft.ML.NugetPackageVersionUpdater/Program.cs |
Updates central package versions during nightly builds. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
NU1010when restoringMicrosoft.ML.NightlyBuild.Testsor the full solution.The Central Package Management conversion removed the placeholder versions from the nightly package references without adding corresponding
PackageVersionitems. This caused solution restore, including restore initiated by C# Dev Kit, to fail.Changes
PackageVersionitems for the nightly-build dependencies.Microsoft.MLpackage version used byTestFrameworkDependency.props.Microsoft.ML.NugetPackageVersionUpdaterto rewritePackageVersionitems instead ofPackageReferenceitems.Validation
Microsoft.ML.NightlyBuild.TestswithReferenceTypeForTestFramework=NuGet.Microsoft.ML.sln.Microsoft.ML.NugetPackageVersionUpdater.