Conversation
…. Moved 'intervals' to test_q as the parameter was only used to demonstrate resumed learning and is not used during normal training
…gument, not steps. The old version was incorrect for self.dt!=1.0
| def test_intervals(crane: Callable[..., Crane]): | ||
| """Test that learning / saving / resuming learning works:""" | ||
| save_path = Path.cwd() / "q_interval_1.json" | ||
| env = AntiPendulumEnv( |
Collaborator
There was a problem hiding this comment.
@eisDNV Do you need to check this environment with ppo agent as well?
Collaborator
Author
There was a problem hiding this comment.
Changes with the agent should not be necessary, but my change might affect results if you use dt!=1.0 for the environment (which you should, since 1.0 is too big a time step).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added explicit time in AntiPendulumEnvironment, so that this can be used in do_step(current_time, step_size) function. Previously 'steps' were used which is wrong when step_size != 1.0