Skip to content

fix(debug): remove incorrect assert for nullptr in Overlap and EKinet… #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 1 commit into from
Jun 9, 2026
+0 −2
Merged

fix(debug): remove incorrect assert for nullptr in Overlap and EKinet… #7460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion source/source_lcao/module_operator_lcao/ekinetic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ hamilt::EKinetic<hamilt::OperatorLCAO<TK, TR>>::EKinetic(
this->ucell = ucell_in;
#ifdef __DEBUG
assert(this->ucell != nullptr);
assert(this->hsk != nullptr);
#endif
// initialize HR to allocate sparse Ekinetic matrix memory
// Only initialize if hR_in is not nullptr (for force calculation, hR_in can be nullptr)
Expand Down
1 change: 0 additions & 1 deletion source/source_lcao/module_operator_lcao/overlap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ hamilt::Overlap<hamilt::OperatorLCAO<TK, TR>>::Overlap(HS_Matrix_K<TK>* hsk_in,
this->SR = SR_in;
#ifdef __DEBUG
assert(this->ucell != nullptr);
assert(this->SR != nullptr);
#endif
// Initialize SR to allocate sparse overlap matrix memory.
// Only initialize if SR_in is not nullptr (for force calculation, SR_in can be nullptr).
Expand Down
Loading