fix(debug): remove incorrect assert for nullptr in Overlap and EKinet…#7460
Merged
Merged
Conversation
…ic constructors Remove assert(this->SR != nullptr) in Overlap constructor and assert(this->hsk != nullptr) in EKinetic constructor. These pointers can be nullptr in normal operation (e.g., for force calculation), so the assert was incorrectly triggering when DEBUG_INFO=ON. Fixes deepmodeling#7021
mohanchen
approved these changes
Jun 9, 2026
mohanchen
left a comment
mohanchen
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, sounds reasonable.
mohanchen
added
Bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #7021
Unit Tests and/or Case Tests for my changes
No additional tests required. This is a simple fix removing incorrect assert statements.
What's changed?
assert(this->SR != nullptr)in Overlap constructorassert(this->hsk != nullptr)in EKinetic constructor-DDEBUG_INFO=ONAny changes of core modules? (ignore if not applicable)
No changes to core modules. Only removed incorrect assert statements in constructors