Skip to content

Reassure users while the picker loads more rows #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xsh310 wants to merge 1 commit into from
Open

Reassure users while the picker loads more rows #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ucode/ui/interactive_picker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def scrolling_checkbox(
on screen: it's run on a daemon thread and handed an ``append(choices)`` callback that
adds rows (deduped by value) and repaints, so the picker opens instantly on whatever
``choices`` are ready and fills in the rest without blocking. A footer shows a live
"loading more {loading_noun}…" count while it runs.
"Loading more {loading_noun}, this might take a few seconds..." count while it runs.

``show_description`` adds a footer previewing the highlighted row's ``Choice.description``.
It's a separate window rather than questionary's inline ``show_description`` because the
Expand Down Expand Up @@ -183,7 +183,11 @@ def is_loading() -> bool:

def loading_tokens() -> list[tuple[str, str]]:
return [
("class:instruction", f" ⏳ loading more {loading_noun}… ({loading['found']} found)")
(
"class:instruction",
f" ⏳ Loading more {loading_noun}, this might take a few seconds..."
f" ({loading['found']} found)",
)
]

@Condition
Expand Down
Loading