Skip to content

Reassure users while the picker loads more rows - #618

Open
xsh310 wants to merge 1 commit into
skills-mcp-remove-locationfrom
skills-picker-loading-copy
Open

xsh310 wants to merge 1 commit into
skills-mcp-remove-locationfrom
skills-picker-loading-copy

Conversation

@xsh310

@xsh310 xsh310 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

What changed, and why?

Change: Reword the streaming picker's loading footer in src/ucode/ui/interactive_picker.py from ⏳ loading more <noun>… to ⏳ Loading more <noun>, this might take a few seconds... (<n> found).

Why: The catalog walk behind the picker scans every schema in the workspace and can take a few seconds, and the old terse footer read like a hang. The new copy tells the user the wait is expected. The footer is shared, so all three streaming pickers pick it up:

  • skill download → ⏳ Loading more skills, this might take a few seconds... (0 found)
  • skill schemas → ⏳ Loading more skill schemas, this might take a few seconds... (0 found)
  • ug mcp add⏳ Loading more MCP services, this might take a few seconds... (0 found)

How do you know it works?

Testing: uv run ruff check . is clean, and tests/test_interactive_picker.py, tests/test_skills_download.py, and tests/test_mcp.py all pass (234 tests). No test asserted the literal footer text; the two loading_noun assertions still hold, since the caller arguments are unchanged.

This pull request and its description were written by Isaac.

@xsh310
xsh310 added this pull request to stack #576 September 14, 2026 20:47
@xsh310
xsh310 marked this pull request as ready for review September 14, 2026 20:48
@xsh310
xsh310 force-pushed the skills-picker-loading-copy branch from 5ed93f9 to 7a7d7ea Compare September 14, 2026 22:32
@xsh310
xsh310 force-pushed the skills-picker-loading-copy branch 2 times, most recently from 793c664 to 4b7b880 Compare September 15, 2026 01:41
@xsh310
xsh310 force-pushed the skills-picker-loading-copy branch from 4b7b880 to 12153f4 Compare September 15, 2026 03:40
The streaming picker footer read "⏳ loading more <noun>…" during the
background walk, which can read like a hang. Reword it to "⏳ Loading more
<noun>, this might take a few seconds..." so the wait reads as expected.
All three pickers (skills, skill schemas, MCP services) share this footer.

Co-authored-by: Isaac <no-reply@databricks.com>
@xsh310
xsh310 force-pushed the skills-picker-loading-copy branch from 12153f4 to 3364135 Compare September 15, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant