Skip to content

direct: remove the WAL Open created when its header cannot be written #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

direct: remove the WAL Open created when its header cannot be written #6363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bundle/direct/dstate/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,16 @@ func (db *DeploymentState) unlockedOpen(ctx context.Context, path string, withRe
StateVersion: currentStateVersion,
CLIVersion: build.GetInfo().Version,
}
return appendJSONLine(db.walFile, walHead)
if err := appendJSONLine(db.walFile, walHead); err != nil {
// Remove the WAL created just above: O_EXCL means it is ours, and
// without a header it carries nothing to recover. Leaving it makes
// every later open fail, with recovery on the header parse and
// without it on the unexpected WAL file.
db.walFile.Close()
db.walFile = nil
os.Remove(walPath)
return fmt.Errorf("failed to write WAL header to %s: %w", walPath, err)
}
}

return nil
Expand Down
Loading