direct: remove the WAL Open created when its header cannot be written - #6363
Open
denik wants to merge 1 commit into
Open
direct: remove the WAL Open created when its header cannot be written#6363denik wants to merge 1 commit into
denik wants to merge 1 commit into
Conversation
O_EXCL means the file is ours and a WAL without a header carries nothing to recover, but leaving it made every later open fail: on the header parse with recovery, and on the unexpected WAL file without it. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 43dc964
6 interesting tests: 4 SKIP, 1 RECOVERED, 1 flaky
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6330.
If writing the WAL header fails, Open leaves behind the file it just created.
O_EXCLmeans the file is ours and a WAL without a header carries nothing to recover, but leaving it makes every later open fail: on the header parse with recovery, and on the unexpected WAL file without it.