acc: Remove superfluous vector search test.toml - #6352
Merged
Conversation
Not needed because parent's `CloudSlow = true` flipped `Cloud` to `true`. Follow-up will stop that behaviour (CloudSlow should only affect `Cloud = true`). However, this test _should_ actually be `Cloud = true` so this config can be removed.
denik
approved these changes
Aug 24, 2026
janniklasrose
enabled auto-merge
August 24, 2026 09:26
Collaborator
Integration test reportCommit: 1d5ea1e
Top 6 slowest tests (at least 2 minutes):
|
dkling-it
pushed a commit
to dkling-it/cli
that referenced
this pull request
Aug 24, 2026
…6356) ## Changes Cap the wait in `vector_search_indexes/schema_normalization` with `DATABRICKS_BUNDLE_RESOURCE_MAX_WAIT=30`, and move it off `CloudSlow` so it runs on every PR. ## Why databricks#6352 established that this test should run on cloud: the assertion is that the *backend* rewrites `schema_json` into Spark type names, and the test server only mimics that. But inheriting `CloudSlow = true` left it nightly-only, at 12-18 minutes per env — one of the four slowest tests in the nightly on every cloud, effectively all of it waiting for the index to provision. Nothing here needs a queryable index, only the created spec and a clean re-plan, so the wait can be capped. 18m24s -> 1m18s on aws linux, verified against a real workspace. The golden did not change, which also confirms the backend's normalized schema still matches what the test server produces. ## Tests `testme-env aws-cli` on the test directory: passes in 78s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not needed because parent's
CloudSlow = trueflippedCloudtotrue.Follow-up (#6354) will stop that behaviour (CloudSlow should only affect
Cloud = true).However, this test should actually be
Cloud = trueso this config can be removed.