acc: cap the wait in the vector search index schema test - #6356
Merged
Conversation
Collaborator
Integration test reportCommit: 4561487
Top 8 slowest tests (at least 2 minutes):
|
It reached cloud by accident: Cloud=false was overridden by the inherited CloudSlow=true, and it cost 12-18 minutes per env there. The assertion is that the backend rewrites schema_json, which the test server only mimics, so the cloud run is worth keeping: make it explicit and cap the wait. 18m24s to 1m18s on aws. Co-authored-by: Isaac
denik
force-pushed
the
denik/schema-norm-cap
branch
from
August 24, 2026 11:20
bf60698 to
4561487
Compare
denik
enabled auto-merge
August 24, 2026 12:42
janniklasrose
approved these changes
Aug 24, 2026
denik
added a commit
that referenced
this pull request
Aug 24, 2026
The test.toml added in #6356 was generated before RequiresUnityCatalog was removed, so its out.test.toml still carried the setting. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cap the wait in
vector_search_indexes/schema_normalizationwithDATABRICKS_BUNDLE_RESOURCE_MAX_WAIT=30, and move it offCloudSlowso it runs on every PR.Why
#6352 established that this test should run on cloud: the assertion is that the backend rewrites
schema_jsoninto Spark type names, and the test server only mimics that. But inheritingCloudSlow = trueleft it nightly-only, at 12-18 minutes per env — one of the four slowest tests in the nightly on every cloud, effectively all of it waiting for the index to provision.Nothing here needs a queryable index, only the created spec and a clean re-plan, so the wait can be capped. 18m24s -> 1m18s on aws linux, verified against a real workspace. The golden did not change, which also confirms the backend's normalized schema still matches what the test server produces.
Tests
testme-env aws-clion the test directory: passes in 78s.