Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/deprecate-dims #1304 +/- ##
==========================================================
+ Coverage 94.05% 94.07% +0.01%
==========================================================
Files 97 97
Lines 5976 5996 +20
Branches 776 778 +2
==========================================================
+ Hits 5621 5641 +20
Misses 227 227
Partials 128 128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 0.0% fully typed (0 / 5)
Patch symbol details
|
7bcf3d0 to
0c87d2e
Compare
a9f5c57 to
c6e0c8d
Compare
7d7efdc to
4253b6e
Compare
4253b6e to
8b192f3
Compare
648f416 to
5f1ec67
Compare
5f1ec67 to
6f80d83
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f80d83. Configure here.
1753fb1 to
f9b73b4
Compare
9952d4f to
1b2a7c9
Compare
…1012, #1013) - Encapsulate internal date dimensions into _odims and _ddims - Provide backward-compatible odims and ddims properties emitting FutureWarning - Migrate legacy pickled instances with odims/ddims in Triangle.__setstate__ - Decouple internal usages across core, estimators, tails, and tests - Address ruff linting and formatting on touched files Closes #1012, closes #1013, refs #1216, refs #601
1b2a7c9 to
5668b6d
Compare

Summary of Changes
Related GitHub Issue(s)
Closes #1012, closes #1013, refs #601, refs #1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Medium Risk
Wide refactor of origin/development axis handling touches core Triangle behavior and many estimators; legacy access still works but pickle migration and slicing/_slice axis naming changes could affect edge-case callers.
Overview
Deprecates direct use of
Triangle.odimsandTriangle.ddimsin favor of the publicoriginanddevelopmentAPIs, while keeping backward compatibility.Internal axis storage is renamed to
_odims/_ddimsacross core triangle logic (slicing, arithmetic alignment, I/O, valuation math) and downstream estimators (development, methods, tails, bootstrap, concat). Library code now mutates the private fields so deprecation warnings are not triggered internally.odimsandddimsremain as compatibility properties that emitFutureWarningon get/set and delegate to the private arrays.Triangle.__setstate__is extended to migrate pickles that still storeodims/ddims(alongside existingkdims/vdimshandling).Tests are updated to assert on
origin/development(or_odims/_ddimswhere appropriate), with new coverage for deprecation warnings and legacy unpickling.Reviewed by Cursor Bugbot for commit 5668b6d. Bugbot is set up for automated code reviews on this repo. Configure here.