Repository navigation
Conversation
priyam0k
added this pull request to stack #1437
October 2, 2026 13:17
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 50.0% fully typed (2 / 4)
Patch symbol details
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/deprecate-date-dims #1454 +/- ##
===============================================================
+ Coverage 94.07% 94.12% +0.04%
===============================================================
Files 97 97
Lines 5996 6044 +48
Branches 778 790 +12
===============================================================
+ Hits 5641 5689 +48
+ Misses 227 226 -1
- Partials 128 129 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
priyam0k
marked this pull request as ready for review
October 2, 2026 14:31
priyam0k
requested review from
genedan,
henrydingliu and
kennethshsu
as code owners
October 2, 2026 14:31
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
from
October 2, 2026 23:08
dec0dbe to
2e30a85
Compare
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
from
October 3, 2026 06:47
2e30a85 to
656767a
Compare
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
2 times, most recently
from
October 3, 2026 08:28
c1996e6 to
de7b967
Compare
3 of 11 tasks
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
from
October 3, 2026 15:57
de7b967 to
1c2d341
Compare
priyam0k
removed this pull request from stack #1437
October 3, 2026 16:54
priyam0k
added this pull request to stack #1459
October 3, 2026 16:55
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
from
October 7, 2026 03:33
1c2d341 to
e0659b6
Compare
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
2 times, most recently
from
October 9, 2026 14:38
eb6567d to
5d1a3c6
Compare
priyam0k
force-pushed
the
feature/centralized-axis-mapping
branch
from
October 11, 2026 17:16
5d1a3c6 to
deecc2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Closes #1053
AI/LLM Usage
Used basic model for initial unit test drafting and lint checks.
Additional Context for Reviewers
Follow-up to Issue #1053, stacked directly on top of #1304 (Stack #1437). Can be reviewed here and retargeted to main once Stack #1437 finishes merging.
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist
Note
Medium Risk
Touches core Triangle axis storage, assignment, and unpickling paths; behavior is intended to be preserved but regressions could affect slicing, renaming, and serialized workflows.
Overview
Centralizes Triangle axis handling by moving shared name/number resolution into
utility_functions(re-exported fromcore.typing) and routingTrianglePandas._get_axis_number/TriangleBase._get_axis_valuethrough those helpers instead of local dicts.Migrates
originanddevelopmenttoTriangleAxisdescriptors (likeindex/columns): getter/setter logic lives inchainladder/core/axis.py, raw timestamps/lags are stored in_axes[2]/_axes[3]via_odims/_ddimssetters, andTriangle._set_axisassigns any axis by name or index.Pickle
__setstate__now normalizes legacyodims/ddims/origin/developmentkeys into_axesand drops redundant state. Tests cover_set_axis, descriptor edge cases (patterns, valuation triangles), and expanded legacy unpickling.Reviewed by Cursor Bugbot for commit deecc2a. Bugbot is set up for automated code reviews on this repo. Configure here.