Bump spirit to @main#12
Open
morgo wants to merge 1 commit into
Open
Conversation
Migrate chunker construction to the new spirit API: table.NewCompositeChunker was removed and table.NewChunker's signature changed to take a table.ChunkerConfig struct. Updated all three call sites (pkg/stage, pkg/archive, pkg/parquet test). go build ./... and go vet ./... pass.
Closed
There was a problem hiding this comment.
Pull request overview
Updates github.com/block/spirit to the latest main commit and adjusts polt’s chunker construction code to the new Spirit API (table.NewChunker(*TableInfo, table.ChunkerConfig)), replacing the removed table.NewCompositeChunker and older NewChunker call patterns.
Changes:
- Bump
github.com/block/spirittov0.15.2-0.20260702163828-5b931ace8482and refresh transitive dependencies (notablyx/text,x/tools,x/sync,kong, etc.). - Migrate all in-repo chunker construction call sites to
table.NewChunker(..., table.ChunkerConfig{...}). - Update the parquet write-buffer test to use the new chunker config-based constructor.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/stage/stager.go | Replaces removed NewCompositeChunker with NewChunker + ChunkerConfig (Key/Where moved into config). |
| pkg/archive/buffer_stager.go | Updates chunker construction to the new NewChunker signature using ChunkerConfig (including NewTable). |
| pkg/parquet/write_buffer_test.go | Updates test chunker creation to NewChunker + ChunkerConfig. |
| go.mod | Bumps Spirit and related direct/indirect module requirements. |
| go.sum | Updates checksums for the bumped dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
github.com/block/spiritdependency to the latestmain(5b931ac). polt'smainwas on a much older spirit (v0.12.1, Apr 2026), so this also pulls in transitive updates (x/text, x/tools).The new spirit changed the chunker construction API:
table.NewCompositeChunker(...)was removed.table.NewChunkernow takes(t *table.TableInfo, config table.ChunkerConfig)instead of positional args.Migrated all three call sites accordingly:
pkg/stage/stager.go(wasNewCompositeChunker;Key/Wherenow set on the config, which forces the composite chunker as before)pkg/archive/buffer_stager.gopkg/parquet/write_buffer_test.gogo build ./...andgo vet ./...pass. Supersedes the earlier draft #11.🤖 Generated with Claude Code