Skip to content

Bump spirit to @main#11

Closed
morgo wants to merge 1 commit into
block:mainfrom
morgo:bump-spirit-main-20260629
Closed

Bump spirit to @main#11
morgo wants to merge 1 commit into
block:mainfrom
morgo:bump-spirit-main-20260629

Conversation

@morgo

@morgo morgo commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Bumps the github.com/block/spirit dependency to the latest main (v0.15.2-0.20260630130838-0df21ada57a0).

Updated via go get github.com/block/spirit@main && go mod tidy, on top of current main. Transitive bumps pulled in by the new spirit:

  • github.com/alecthomas/kong v0.8.0v1.15.0 (now required by spirit; usage is plain kong.Parse + struct tags, compatible with v1)
  • golang.org/x/sync v0.20.0v0.21.0

No polt code changes are required. main already migrated to the new chunker API (table.NewChunker) in #10, and every spirit API polt depends on (table.Chunker interface, dbconn.BeginStandardTrx, throttler) is unchanged across v0.15.1v0.15.2. The only spirit API changes in that range (dbconn.RetryableTransaction dup-key enum, copier ETA, checksum refactors) are not used by polt.

Verified locally: go build ./..., go vet ./..., golangci-lint run (0 issues). Database tests run in CI.

Note: this branch was rebuilt on top of current main. The earlier revision had been branched from a stale fork main (still on spirit v0.12.1, pre-#10), so it reintroduced the removed table.NewCompositeChunker and didn't compile. That's resolved here.

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings June 29, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s Go module dependencies, primarily bumping github.com/block/spirit to a newer main-based pseudo-version, which in turn updates a number of transitive dependencies.

Changes:

  • Bump github.com/block/spirit to v0.15.2-0.20260629112820-8f451ff83766.
  • Refresh go.mod / go.sum via go get + go mod tidy, updating several direct and indirect dependencies (e.g., golang.org/x/*, go-sql-driver/mysql, klauspost/compress).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates direct/indirect module requirements, including the spirit bump and resulting transitive version changes.
go.sum Updates checksum entries to match the new resolved module graph after the dependency bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod Outdated
Bumps github.com/block/spirit to the latest main
(v0.15.2-0.20260630130838-0df21ada57a0). Transitively upgrades
alecthomas/kong v0.8.0 -> v1.15.0 (now required by spirit) and
golang.org/x/sync v0.20.0 -> v0.21.0.

No polt code changes are required: the spirit APIs polt uses
(table.NewChunker/Chunker, dbconn.BeginStandardTrx, throttler) are
unchanged in this range.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@morgo morgo force-pushed the bump-spirit-main-20260629 branch from ad0b844 to 03f5da5 Compare June 30, 2026 14:32
@morgo morgo marked this pull request as ready for review June 30, 2026 14:32
@morgo morgo mentioned this pull request Jul 3, 2026
@morgo

morgo commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Superseded by #12, which bumps to the latest spirit main and includes the chunker API migration so it compiles.

@morgo morgo closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants