Render phase changes

[MoRusty]

Objective

• Issue with changing light source in the pbr example.
• Fixes pcss, clustered_decal_maps, mixed_lighting examples panic on main #24973 same issue is also on mixed_lighting

Solution

• in render_phase, instance count was being incremented whether or not the entity got added to the RenderBinnedMeshInstanceIndex. went with a bool because the count also needs to be changed for the gpubuffer

Testing

• Did you test these changes? If so, how?
  ran both examples

  cargo run --example mixed_lighting --features="jpeg"
  cargo run --example pcss --features="experimental_pbr_pcss"

• Are there any parts that need more testing? Any other example that uses the Bevy_Render crate
• How can other people (reviewers) test your changes? Is there anything specific they need to know?
• If relevant, what platforms did you test these changes on, and are there any important ones you can't test? N/A

---

[MoRusty]

@kfc35 made a different PR for it and closed the previous one

[kfc35]

Thank you for fixing this! Quick work, and nice catch!

I can confirm that all the affected examples that I found are fixed with this PR.

[pcwalton]

This was not the correct fix. Binning a mesh instance that is already binned is always illegal and is going to cause problems. The right fix is to fix the circumstances that cause us to bin meshes twice in the first place, such as #24984. I know that that PR alone didn’t fix the PCSS crash, but I’m looking into why that is happening.

[MoRusty]

@pcwalton Understood, I was assuming the duplicate binning was related to deferred component changes on the same entity, especially in the PCSS crash path, where insert/remove operations may not be reflected immediately. I’m reading through #24984