Migrate pcss example to use FeathersRadio#24974
Open
kfc35 wants to merge 6 commits into
Open
Conversation
pcss example to use FeathersRadioButtonpcss example to use FeathersRadioButton
pcss example to use FeathersRadioButtonpcss example to use FeathersRadio
Contributor
|
I tried running the example but on this branch it consistently panics deep inside the renderer, which doesn't happen on main. I have no idea how your changes could cause this though. |
Contributor
Author
I encountered this last night and concluded that my changes are mostly unrelated to the panic. I can get the panic to happen on main when I switch the light type so I spun out #24973 However it did make me wonder a tiny bit why moving to feathers sometimes makes it panic by itself. I cant see obviously why the light type would change on initialization but ill see what I can figure out |
Contributor
Author
|
The panicking should be resolved by #24980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
radio.rsfirst.pcssnow usesbsn!to spawn the buttons only, so the example has a mix of regular spawns and spawn scenes.Once this is merged, phase 4 is unblocked to use these new methods for converting the other examples mentioned.
Testing
cargo run --example pcss --features="experimental_pbr_pcss,bevy_feathers”Showcase
Before and After
Before:

After:
https://github.com/user-attachments/assets/c8713ce4-b852-4fca-a62e-100f8c8ba16a