Extract shared sandbox-project test helpers#2087
Merged
Merged
Conversation
Collapse the copy-paste that had accumulated across the search/replace and project specs into projectile-test-helpers: - projectile-test-project-root - the (file-truename (expand-file-name "project/")) incantation appeared ~48 times. - projectile-test-kill-project-buffers - three near-identical copies (the superset version kills the project buffers and both result buffers). - projectile-test-use-plain-grep - three identical copies. - projectile-test-disk / projectile-test-disk-raw - the on-disk content readers, now available to every spec. No behavior change; 889 specs green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure dedup - the first (low-risk) half of the test-helper consolidation. No behavior change, 11 files touched, ~200 lines of copy-paste removed.
Moved into
projectile-test-helpers:projectile-test-project-root- the(file-truename (expand-file-name "project/"))incantation appeared ~48 times.projectile-test-kill-project-buffers- three near-identical copies (the shared version kills the project buffers and both result buffers, a harmless superset).projectile-test-use-plain-grep- three identical copies.projectile-test-disk/projectile-test-disk-raw- the on-disk content readers, now available to every spec.889 specs green, clean
--warnings-as-errors, relint clean.The bigger
--with-projectmacro consolidation (four near-identical per-file macros) is the follow-up - it needs care around the case-handling bindings, so it's its own PR.