Consolidate the four --with-project test macros#2088
Merged
Conversation
The replace, replace-review, scan-async and search-review suites each carried a near-identical --with-project macro (sandbox, create files, truename'd root, native indexing, fresh caches, stubbed project-root). Replace them with a single projectile-test-with-project in the shared helpers. Three suites now call it directly; the replace suite keeps its own thin macro that delegates to the shared one and adds the smart-case bindings (search-upper-case / case-replace) its case-sensitivity specs rely on. No behavior change; 889 specs green, including the case-sensitivity specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up to #2087. The replace, replace-review, scan-async and search-review suites each defined a near-identical
--with-projectmacro (sandbox → create files → truename'd root → native indexing → fresh caches → stubbedproject-root). Collapse them into a singleprojectile-test-with-projectin the shared helpers.Three suites call it directly. The replace suite keeps a thin macro that delegates to the shared one and layers on the
search-upper-case/case-replacebindings its case-sensitivity specs depend on - so those specs keep their exact semantics (verified: "keeps case sensitivity", "re-scans when case sensitivity flips" et al. still pass).Net ~80 fewer lines; no behavior change. 889 specs green, clean
--warnings-as-errors, relint clean.