Skip to content

Leave Previously Seen out of the mail help bar #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monorkin merged 1 commit into from
Sep 8, 2026
Merged

Leave Previously Seen out of the mail help bar #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/tui/mail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,7 +1060,6 @@ func (v *mailView) HelpBindings() []helpBinding {
helpBinding{"t", "trash"},
helpBinding{"!", "spam"},
ignoreBinding,
helpBinding{"9", "previously seen"},
helpBinding{"ctrl+r", "reload"},
)
if v.postingList.cover != coverNone {
Expand Down
12 changes: 4 additions & 8 deletions internal/tui/mail_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4101,22 +4101,18 @@ func TestMailViewMovePickerOnTheSeenScreenLeavesTheImboxOut(t *testing.T) {
}
}

func TestMailViewHelpBindingsNamePreviouslySeen(t *testing.T) {
// Previously Seen holds ordinary threads, so its screen offers the same actions the
// box list does rather than being a place you can only read from.
func TestMailViewSeenScreenHelpOffersTheThreadActions(t *testing.T) {
v := mailWithPostings()
if !hasHelpBinding(v.HelpBindings(), "9") {
t.Error("the list help should name 9")
}

v.seenActive = true

bindings := v.HelpBindings()
for _, key := range []string{"enter", "space", "ctrl+b", "a", "l", "u", "t", "v", "b", "n"} {
if !hasHelpBinding(bindings, key) {
t.Errorf("seen screen help misses %q: %+v", key, bindings)
}
}
if hasHelpBinding(bindings, "9") {
t.Error("the seen screen help should not name 9")
}
}

func TestMailViewRefusesAPostingWithoutAThread(t *testing.T) {
Expand Down
Loading